On Tue, May 12, 2020 at 09:29:36AM +0300, Leon Romanovsky wrote: > On Mon, May 11, 2020 at 09:37:42PM +0300, Dan Carpenter wrote: > > This function used to always return -EINVAL but we updated it to try > > preserve the error codes. Unfortunately the copy_to_user() is returning > > the number of bytes remaining to be copied instead of a negative error > > code. > > > > Fixes: a3a974b4654d ("RDMA/rxe: Always return ERR_PTR from rxe_create_mmap_info()") > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > --- > > drivers/infiniband/sw/rxe/rxe_queue.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > Thanks, > Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> Actually Yanjun is right and "err" can be removed. Thanks