Re: [PATCH for-next 2/2] RDMA/efa: Report host information to the device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gal,

I love your patch! Yet something to improve:

[auto build test ERROR on rdma/for-next]
[also build test ERROR on v5.7-rc4 next-20200508]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Gal-Pressman/EFA-host-information/20200510-200519
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/infiniband/hw/efa/efa_main.c: In function 'efa_set_host_info':
>> drivers/infiniband/hw/efa/efa_main.c:214:21: error: 'LINUX_VERSION_CODE' undeclared (first use in this function)
     214 |  hinf->kernel_ver = LINUX_VERSION_CODE;
         |                     ^~~~~~~~~~~~~~~~~~
   drivers/infiniband/hw/efa/efa_main.c:214:21: note: each undeclared identifier is reported only once for each function it appears in

vim +/LINUX_VERSION_CODE +214 drivers/infiniband/hw/efa/efa_main.c

   190	
   191	static void efa_set_host_info(struct efa_dev *dev)
   192	{
   193		struct efa_admin_set_feature_resp resp = {};
   194		struct efa_admin_set_feature_cmd cmd = {};
   195		struct efa_admin_host_info *hinf;
   196		u32 bufsz = sizeof(*hinf);
   197		dma_addr_t hinf_dma;
   198	
   199		if (!efa_com_check_supported_feature_id(&dev->edev,
   200							EFA_ADMIN_HOST_INFO))
   201			return;
   202	
   203		/* Failures in host info set shall not disturb probe */
   204		hinf = dma_alloc_coherent(&dev->pdev->dev, bufsz, &hinf_dma,
   205					  GFP_KERNEL);
   206		if (!hinf)
   207			return;
   208	
   209		strlcpy(hinf->os_dist_str, utsname()->release,
   210			min(sizeof(hinf->os_dist_str), sizeof(utsname()->release)));
   211		hinf->os_type = EFA_ADMIN_OS_LINUX;
   212		strlcpy(hinf->kernel_ver_str, utsname()->version,
   213			min(sizeof(hinf->kernel_ver_str), sizeof(utsname()->version)));
 > 214		hinf->kernel_ver = LINUX_VERSION_CODE;
   215		EFA_SET(&hinf->bdf, EFA_ADMIN_HOST_INFO_BUS, dev->pdev->bus->number);
   216		EFA_SET(&hinf->bdf, EFA_ADMIN_HOST_INFO_DEVICE,
   217			PCI_SLOT(dev->pdev->devfn));
   218		EFA_SET(&hinf->bdf, EFA_ADMIN_HOST_INFO_FUNCTION,
   219			PCI_FUNC(dev->pdev->devfn));
   220		EFA_SET(&hinf->spec_ver, EFA_ADMIN_HOST_INFO_SPEC_MAJOR,
   221			EFA_COMMON_SPEC_VERSION_MAJOR);
   222		EFA_SET(&hinf->spec_ver, EFA_ADMIN_HOST_INFO_SPEC_MINOR,
   223			EFA_COMMON_SPEC_VERSION_MINOR);
   224		EFA_SET(&hinf->flags, EFA_ADMIN_HOST_INFO_INTREE, 1);
   225	
   226		efa_com_set_feature_ex(&dev->edev, &resp, &cmd, EFA_ADMIN_HOST_INFO,
   227				       hinf_dma, bufsz);
   228	
   229		dma_free_coherent(&dev->pdev->dev, bufsz, hinf, hinf_dma);
   230	}
   231	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux