On Thu, May 07, 2020 at 04:24:32PM +0100, Edward Cree wrote: > On 07/05/2020 16:06, Greg KH wrote: > > I can't accept that this series is using a virtual bus properly without > > actually using the virtual bus driver code, can you? > I might be misunderstanding, but I *think* a hardware driver likeice is > the 'provider' of a virtbus, and it's only 'consumers' of it (like an > RDMA device talking to that ice instance) that are virtbus_drivers. > Though tbh I'm not entirely happy either with a series that adds the > provider side but not any users... and either way, the documentation > *really* doesn't make it clear whether it works the way I think it does > or not. Exactly, I can't tell anything from the documentation at all, so I looked at how the code was used. That just made things worse... This needs more work. greg k-h
