On Mon, May 4, 2020 at 10:42 AM David Ahern <dsahern@xxxxxxxxx> wrote: > > On 5/4/20 8:36 AM, Jarod Wilson wrote: > > At a glance, I'm not sure why all the "get the xmit slave" functions > > are being passed an skb. None of them should be manipulating the skb, > > that should all be done in the respective xmit functions after the > > slave has been returned. > > a number of them select a slave based on hash of the packet data -- from > ethernet data only to L3+L4 hashing. Ah, right, I see it now for the 3ad/xor case. So it makes sense to pass it into the ndo, but for example bond_xmit_activebackup_slave_get() simply does "return rcu_dereference(bond->curr_active_slave);", so no real need to pass it skb. The per-mode functions are all static, could drop the unneeded passing of skb there. Looks like v8 is already merged though, so meh. -- Jarod Wilson jarod@xxxxxxxxxx
