On Wed, Apr 29, 2020 at 12:01:07PM +0300, Maor Gottlieb wrote: > > On 4/29/2020 2:30 AM, Jason Gunthorpe wrote: > > On Tue, Apr 28, 2020 at 08:15:25PM -0300, Jason Gunthorpe wrote: > > > On Sun, Apr 26, 2020 at 10:17:12AM +0300, Maor Gottlieb wrote: > > > > +int rdma_lag_get_ah_roce_slave(struct ib_device *device, > > > > + struct rdma_ah_attr *ah_attr, > > > > + struct net_device **xmit_slave) > > > Please do not use ** and also return int. The function should return > > > net_device directly and use ERR_PTR() > > How about return NULL in failure as well (will add debug print)? Not fail > the flow if we didn't succeed to get the slave, let the lower driver to do > it if it would like to. A NULL return indicating success but 'not found' is fine. Jason
