On Mon, Apr 27, 2020 at 05:55:57PM +0000, Saleem, Shiraz wrote: > > Subject: [PATCH for-next] RDMA/core: Assign the name of device when allocating > > ib_device > > > > If the name of a device is assigned during ib_register_device(), some drivers have > > to use dev_*() for printing before register device. Bring > > assign_name() into ib_alloc_device(), so that drivers can use ibdev_*() anywhere. > > > > Signed-off-by: Weihang Li <liweihang@xxxxxxxxxx> > > drivers/infiniband/core/device.c | 85 +++++++++++++------------- > > drivers/infiniband/hw/bnxt_re/main.c | 4 +- > > drivers/infiniband/hw/cxgb4/device.c | 2 +- > > drivers/infiniband/hw/cxgb4/provider.c | 2 +- > > drivers/infiniband/hw/efa/efa_main.c | 4 +- > > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +- > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +- > > drivers/infiniband/hw/hns/hns_roce_main.c | 2 +- > > drivers/infiniband/hw/i40iw/i40iw_verbs.c | 4 +- > > drivers/infiniband/hw/mlx4/main.c | 4 +- > > drivers/infiniband/hw/mlx5/ib_rep.c | 8 ++- > > drivers/infiniband/hw/mlx5/main.c | 18 +++--- > > drivers/infiniband/hw/mthca/mthca_main.c | 2 +- > > drivers/infiniband/hw/mthca/mthca_provider.c | 2 +- > > drivers/infiniband/hw/ocrdma/ocrdma_main.c | 4 +- > > drivers/infiniband/hw/qedr/main.c | 4 +- > > drivers/infiniband/hw/usnic/usnic_ib_main.c | 4 +- > > drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 4 +- > > drivers/infiniband/sw/rxe/rxe.c | 4 +- > > drivers/infiniband/sw/rxe/rxe.h | 2 +- > > drivers/infiniband/sw/rxe/rxe_net.c | 4 +- > > drivers/infiniband/sw/rxe/rxe_verbs.c | 4 +- > > drivers/infiniband/sw/rxe/rxe_verbs.h | 2 +- > > include/rdma/ib_verbs.h | 8 +-- > > 24 files changed, 95 insertions(+), 86 deletions(-) > > I think you ll need to update siw driver similarly. > > rvt_register_device should be adapted to use the revised device registration API. > hfi1/qib also need some rework. It is necessary to make such a big change? :( > rvt_alloc_device needs to be adapted for the new one-shot > name + device allocation scheme. > Hoping we can just use move the name setting from rvt_set_ibdev_name I thought so.. Jason
