On 4/27/2020 9:04 AM, Christoph Hellwig wrote:
On Sun, Apr 26, 2020 at 12:48:18PM +0300, Max Gurtovoy wrote:
I see no reason not to support a simple Format NVM for our fabrics target
implementation. But that isn't the point - you don't really need Format
as you can also control it from configfs in your series. So for the
initial version I don't think we need Format NVM, but I don't mind
adding it later.
so we're ok with passing -p in nvme-cli during connect command ?
PI should be enable by default. We can think of a hook disabling it,
but please keep it at the end of the series.
but the default format on NVMe pci drives is without metadata and to
enable it we do an NVM format command.
So for this model we need to do some action to enable T10/Metadata.
Regular users will usually use default configuration and are not aware
of the pros/cons with adding the metadata (resources/performance/etc..).
Also adding module param as we did in iSER is less flexible than having
a flag per controller in the CLI.
I'll think about another option that will replace -p in connect command
(the only one I can think of now is always "on" as suggested...)
