On Thu, Apr 23, 2020 at 03:09:47PM +0300, Max Gurtovoy wrote:
>
> On 4/21/2020 6:24 PM, Christoph Hellwig wrote:
>> On Fri, Mar 27, 2020 at 08:15:41PM +0300, Max Gurtovoy wrote:
>>> From: Israel Rukshin <israelr@xxxxxxxxxxxx>
>>>
>>> The enumerations will be used to expose the namespace metadata format by
>>> the target.
>>>
>>> Signed-off-by: Israel Rukshin <israelr@xxxxxxxxxxxx>
>>> Reviewed-by: Max Gurtovoy <maxg@xxxxxxxxxxxx>
>> I'd be tempted to use a separate enum and add a comment to which field
>> this relates.
>
> something like:
>
> +/* Metadata Capabilities */
> +enum {
> + /* supports metadata being transferred as part of an extended LBA */
> + NVME_NS_MC_META_EXT = 1 << 0,
> + /* supports metadata being transferred as part of a separate
> buffer */
> + NVME_NS_MC_META_BUF = 1 << 1,
> +};
What about:
/* Identify Namespace Metadata Capabilities (MC): */
enum {
NVME_MC_METADATA_PTR = (1 << 0),
NVME_MC_EXTENDED_LBA = (1 << 1),
};
