On Thu, Apr 23, 2020 at 01:07:47AM +0300, Max Gurtovoy wrote: > > On 4/21/2020 6:17 PM, Christoph Hellwig wrote: >> On Fri, Mar 27, 2020 at 08:15:33PM +0300, Max Gurtovoy wrote: >>> From: Israel Rukshin <israelr@xxxxxxxxxxxx> >>> >>> Preparation for adding metadata (T10-PI) over fabric support. This will >>> allow end-to-end protection information passthrough and validation for >>> NVMe over Fabric. >> So actually - for PCIe we enable PI by default. Not sure why RDMA would >> be any different? If we have a switch to turn it off we probably want >> it work similar (can't be the same due to the lack of connect) for PCIe >> as well. > > For PCI we use a format command to configure metadata. In fabrics we can > choose doing it in the connect command and we can also choose to have > "protected" controllers and "non-protected" controllers. > > I don't think it's all or nothing case, and configuration using nvme-cli > (or other tool) seems reasonable and flexible. Format applies to a namespace and is not limited to PCIe.