On 4/21/2020 4:59 AM, Christoph Hellwig wrote:
On Fri, Mar 27, 2020 at 08:15:29PM +0300, Max Gurtovoy wrote:
From: Israel Rukshin <israelr@xxxxxxxxxxxx>
Centralize all the metadata checks to one place and make the code more
readable. Introduce a new enum nvme_ns_features for that matter.
The features flag description:
- NVME_NS_EXT_LBAS - NVMe namespace supports extended LBA format.
- NVME_NS_MD_HOST_SUPPORTED - NVMe namespace supports getting metadata
from host's block layer.
- NVME_NS_MD_CTRL_SUPPORTED - NVMe namespace supports metadata actions
by the controller (generate/strip).
So whole I like the ->features flag, the defintion of these two
metadata related features really confuses me.
Here are my vague ideas to improve the situation:
Care to look at any of the RFC items I posted on 2/24 - which does
things a little differently ? Perhaps find a common ground with Max's
patches.
http://lists.infradead.org/pipermail/linux-nvme/2020-February/029066.html
Granted I've tweaked what I sent a little as there was no need to make
nvme_ns_has_pi accessible to the transport.
-- james
