On Fri, Mar 27, 2020 at 08:15:32PM +0300, Max Gurtovoy wrote: > + /* > + * NVMe PCI driver doesn't support Extended LBA format and supports > + * only a single integrity segment for a separate contiguous buffer > + * of metadata. > + */ That isn't strictly true, PCIe can also support SGLs for metadata. I'd rather ѕay something like: /* * We do not support an SGL for metadata (yet), so we are limited * to a single integrity segment for the separate metadata pointer. */ Except for that this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>