> Subject: Re: [RFC PATCH v5 10/16] RDMA/irdma: Add RoCEv2 UD OP support > > On Fri, Apr 17, 2020 at 10:12:45AM -0700, Jeff Kirsher wrote: > > From: Mustafa Ismail <mustafa.ismail@xxxxxxxxx> > > > > Add the header, data structures and functions to populate the WQE > > descriptors and issue the Control QP commands that support RoCEv2 UD > > operations. > > > > Signed-off-by: Mustafa Ismail <mustafa.ismail@xxxxxxxxx> > > Signed-off-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx> > > --- [..] > > +#define IRDMA_UDA_CQPSQ_QHASH_ENTRYTYPE_S 42 #define > > +IRDMA_UDA_CQPSQ_QHASH_ENTRYTYPE_M \ > > + ((u64)0x7 << IRDMA_UDA_CQPSQ_QHASH_ENTRYTYPE_S) > > GENMASK*() are better suit here instead of shifts. > OK. I think Jason prefers that too. Will look to make that change in the next rev.
