> -----Original Message----- > From: Jason Gunthorpe <jgg@xxxxxxxx> > Sent: Friday, April 17, 2020 12:18 > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx> > Cc: davem@xxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; Ertman, David M > <david.m.ertman@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux- > rdma@xxxxxxxxxxxxxxx; nhorman@xxxxxxxxxx; sassmann@xxxxxxxxxx; > ranjani.sridharan@xxxxxxxxxxxxxxx; pierre-louis.bossart@xxxxxxxxxxxxxxx; Nguyen, > Anthony L <anthony.l.nguyen@xxxxxxxxx>; Bowers, AndrewX > <andrewx.bowers@xxxxxxxxx> > Subject: Re: [net-next 2/9] ice: Create and register virtual bus for RDMA > > On Fri, Apr 17, 2020 at 10:10:27AM -0700, Jeff Kirsher wrote: > > From: Dave Ertman <david.m.ertman@xxxxxxxxx> > > > > The RDMA block does not have its own PCI function, instead it must > > utilize the ice driver to gain access to the PCI device. Create a > > virtual bus device so the irdma driver can register a virtual bus > > driver to bind to it and receive device data. The device data contains > > all of the relevant information that the irdma peer will need to > > access this PF's IIDC API callbacks. > > Can you please provide examples of what the sysfs paths for all this stuff looks > like? [Kirsher, Jeffrey T] Here is an example using ice and irdma driver registered: /sys/bus/virtbus/devices/intel,ice,rdma.7 /sys/bus/virtbus/devices/intel,ice,rdma.5 /sys/bus/virtbus/devices/intel,ice,rdma.6 /sys/bus/virtbus/devices/intel,ice,rdma.4 /sys/bus/virtbus/drivers/irdma/intel,ice,rdma.7 /sys/bus/virtbus/drivers/irdma/intel,ice,rdma.5 /sys/bus/virtbus/drivers/irdma/intel,ice,rdma.6 /sys/bus/virtbus/drivers/irdma/intel,ice,rdma.4 /sys/devices/pci0000:00/0000:00:1c.4/0000:09:00.0/intel,ice,rdma.4 /sys/devices/pci0000:00/0000:00:1c.4/0000:09:00.3/intel,ice,rdma.7 /sys/devices/pci0000:00/0000:00:1c.4/0000:09:00.1/intel,ice,rdma.5 /sys/devices/pci0000:00/0000:00:1c.4/0000:09:00.2/intel,ice,rdma.6 /sys/module/virtual_bus/holders/ice /sys/module/ice /sys/module/ice/drivers/pci:ice /sys/bus/pci/drivers/ice /sys/bus/virtbus/drivers/irdma /sys/module/virtual_bus/holders/irdma /sys/module/irdma /sys/module/irdma/drivers/virtbus:irdma /sys/module/ib_core/holders/irdma /sys/module/ib_uverbs/holders/irdma > > Does power management work right? [Kirsher, Jeffrey T] The power management we tested so far is working. Are you seeing any issue? > > Jason