> > > > +} > > > > +EXPORT_SYMBOL(ib_umem_dmabuf_release); > > > > > > Why is this an EXPORT_SYMBOL? > > > > It is called from ib_umem_release() which is in a different file. > > export is only required to call outside the current module, which is is not. Will fix it. Thanks. > > > > > diff --git a/include/rdma/ib_umem_dmabuf.h > > > > b/include/rdma/ib_umem_dmabuf.h new file mode 100644 index > > > > 0000000..e82b205 > > > > +++ b/include/rdma/ib_umem_dmabuf.h > > > > > > This should not be a public header > > > > It's put there to be consistent with similar headers such as "ib_umem_odp.h". Can be changed. > > ib_umem_odp is needed by drivers, this is not. In the current series, it's used by the mlx5_ib driver. However, if as you suggested the function prototype of ib_umem_dmabuf_get is moved to ib_umem.h, this is no longer needed. > > Jason
