On Thu, Apr 16, 2020 at 06:32:01PM +0000, Xiong, Jianxin wrote: > > > SET_DEVICE_OP(dev_ops, read_counters); > > > SET_DEVICE_OP(dev_ops, reg_dm_mr); > > > SET_DEVICE_OP(dev_ops, reg_user_mr); > > > + SET_DEVICE_OP(dev_ops, reg_user_mr_fd); > > > SET_DEVICE_OP(dev_ops, req_ncomp_notif); > > > SET_DEVICE_OP(dev_ops, req_notify_cq); > > > SET_DEVICE_OP(dev_ops, rereg_user_mr); > > > + SET_DEVICE_OP(dev_ops, rereg_user_mr_fd); > > > > I'm not so found of adding such a specific callback.. It seems better to have a generic reg_user_mr that accepts a ib_umem created by the > > core code. Burying the umem_get in the drivers was probably a mistake. > > I totally agree. But that would require major changes to the uverbs workflow. I don't think it is that bad and would prefer it Jason
