Re: [PATCH for-rc] RDMA/cma: fix race between addr_handler and resolve_route

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On 3 Apr 2020, at 20:57, Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote:
> 
> On Fri, Apr 03, 2020 at 08:43:28PM +0200, Håkon Bugge wrote:
>> A syzkaller test hits a NULL pointer dereference in
>> rdma_resolve_route():
> 
> #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
> 
> This commit in 5.7 probably fixes this:

I think it will not. The mutex in 7c11910783a1 ("RDMA/ucma: Put a lock around every call to the rdma_cm layer") will not prevent addr_handler() to run concurrently with rdma_resolve_route(), right?

And, I also suspect 7c11910783a1 to have major performance impact. But, that's a different story.


Thxs, Håkon




> 
> commit 7c11910783a1ea17e88777552ef146cace607b3c
> Author: Jason Gunthorpe <jgg@xxxxxxxx>
> Date:   Tue Feb 18 15:45:38 2020 -0400
> 
>    RDMA/ucma: Put a lock around every call to the rdma_cm layer
> 
> 
> Lets find out.
> 
> Jason





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux