On Sat, Mar 28, 2020 at 12:31:08PM -0700, Bart Van Assche wrote:
> On 2020-03-20 05:16, Jack Wang wrote:
> > This is the sysfs interface to rnbd mapped devices on server side:
> >
> > /sys/devices/virtual/rnbd-server/ctl/devices/<device_name>/
> > |- block_dev
> > | *** link pointing to the corresponding block device sysfs entry
> > |
> > |- sessions/<session-name>/
> > | *** sessions directory
> > |
> > |- read_only
> > | *** is devices mapped as read only
> > |
> > |- mapping_path
> > *** relative device path provided by the client during mapping
> >
>
> > +static struct kobj_type ktype = {
> > + .sysfs_ops = &kobj_sysfs_ops,
> > +};
>
> From Documentation/kobject.txt: "One important point cannot be
> overstated: every kobject must have a release() method." I think this is
> something that Greg KH feels very strongly about. Please fix this.
more importantly you can't implement kobjects correctly without a
release so there is some bug in here.
Jason
