On 3/19/2020 6:09 AM, Bart Van Assche wrote:
On 2020-03-18 08:02, Max Gurtovoy wrote:
In order to save resource allocation and utilize the completion
^^^^^^^^^^^^^^^^^^^
resources?
thanks.
+static int nvmet_rdma_srq_size = 1024;
+module_param_cb(srq_size, &srq_size_ops, &nvmet_rdma_srq_size, 0644);
+MODULE_PARM_DESC(srq_size, "set Shared Receive Queue (SRQ) size, should >= 256 (default: 1024)");
Is an SRQ overflow fatal? Isn't the SRQ size something that should be
computed by the nvmet_rdma driver such that SRQ overflows do not happen?
I've added the following code to make sure that the size is not greater
than device capability:
+ndev->srq_size = min(ndev->device->attrs.max_srq_wr,
+ nvmet_rdma_srq_size);
In case the SRQ doesn't have enough credits it will send rnr to the
initiator and the initiator will retry later on.
We might need to change the min_rnr_timer during the connection
establishment, but still didn't see the need for it.
-Max
Thanks,
Bart.
