On 3/17/2020 8:10 PM, Jason Gunthorpe wrote:
On Tue, Mar 17, 2020 at 06:37:57PM +0200, Max Gurtovoy wrote:
+#include <rdma/ib_verbs.h>
+
+struct ib_srq *rdma_srq_get(struct ib_pd *pd);
+void rdma_srq_put(struct ib_pd *pd, struct ib_srq *srq);
At the end, it is not get/put semantics but more add/remove.
srq = rdma_srq_add ?
rdma_srq_remove(pd, srq) ?
Doesn't seems right to me.
Lets make it simple. For asking a SRQ from the PD set lets use rdma_srq_get
and returning to we'll use rdma_srq_put.
Is there reference couting here? get/put should be restricted to
refcounting APIs, IMHO.
I've added a counter (pd->srqs_used) that Leon asked to remove .
There is no call to kref get/put here.
Do you prefer that I'll change it to be array in PD: "struct
ib_srq **srqs;" ?
And update ib_alloc_pd API to get pd_attrs and allocate the array during
PD allocation ?
Jason
