On Fri, Mar 13, 2020 at 05:31:34AM -0700, Selvin Xavier wrote:
> Since the lifetime of bnxt_re_task is controlled by
> the kref of device, sched_count is no longer required.
> Remove it.
>
> Signed-off-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>
> drivers/infiniband/hw/bnxt_re/bnxt_re.h | 1 -
> drivers/infiniband/hw/bnxt_re/main.c | 7 -------
> 2 files changed, 8 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/bnxt_re.h b/drivers/infiniband/hw/bnxt_re/bnxt_re.h
> index c736e82..e35cc6c 100644
> +++ b/drivers/infiniband/hw/bnxt_re/bnxt_re.h
> @@ -177,7 +177,6 @@ struct bnxt_re_dev {
> atomic_t srq_count;
> atomic_t mr_count;
> atomic_t mw_count;
> - atomic_t sched_count;
> /* Max of 2 lossless traffic class supported per port */
> u16 cosq[2];
>
> diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
> index 82062d8..4df0f8e 100644
> +++ b/drivers/infiniband/hw/bnxt_re/main.c
> @@ -1670,7 +1670,6 @@ static void bnxt_re_task(struct work_struct *work)
> }
> ib_device_put(&rdev->ibdev);
> smp_mb__before_atomic();
> - atomic_dec(&rdev->sched_count);
All these smp_mb's need to be deleted too
Jason
