On 2020/3/12 17:40, Leon Romanovsky wrote: > On Thu, Mar 12, 2020 at 09:27:39AM +0000, liweihang wrote: >> On 2020/3/12 17:04, Leon Romanovsky wrote: >>> On Thu, Mar 12, 2020 at 02:40:44PM +0800, Weihang Li wrote: >>>> From: Lang Cheng <chenglang@xxxxxxxxxx> >>>> >>>> Depth of qp shouldn't be allowed to be set to zero, after ensuring that, >>>> subsequent process can be simplified. And when qp is changed from reset to >>>> reset, the capability of minimum qp depth was used to identify hardware of >>>> hip06, it should be changed into a more readable form. >>>> >>>> Signed-off-by: Lang Cheng <chenglang@xxxxxxxxxx> >>>> Signed-off-by: Weihang Li <liweihang@xxxxxxxxxx> >>>> Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> >>> >>> I didn't review, please don't add tags before they explicitly posted. >>> https://lore.kernel.org/linux-rdma/1583140937-2223-1-git-send-email-liweihang@xxxxxxxxxx/ >>> >>> Thanks >>> >> >> Sorry, I misunderstood what you mean about the Reviewed-by tag in >> previous discussions. Will remove it and send a new version. > > You are supposed to add those tags if someone writes something like this: > Reviewed-by: .... > > Thanks > I see, thank you. >> >> Thank you >> Weihang >