On Tue, Mar 3, 2020 at 5:28 PM Bart Van Assche <bvanassche@xxxxxxx> wrote: > > On 3/3/20 8:20 AM, Jinpu Wang wrote: > > We tried the above approach and just noticed the bio_map_kern was no > > longer exported since 5.4 kernel. > > We checked target_core_iblock.c and nvme io-cmd-bdev.c, they are open > > coding similar function. > > > > I guess re-export bio_map_kern will not be accepted? > > Do you have suggestion how should we handle it? > > Duplicating code is bad. > > The code in drivers/nvme/target/io-cmd-bdev.c and target_core_iblock.c > is different: it calls bio_add_page() instead of bio_add_pc_page(). > > Please include a patch in this series that reexports bio_map_kern(). Got it, will do it. > > Thanks, > > Bart. > Thanks!
