On Mon, Mar 2, 2020 at 5:13 PM Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> On 3/2/20 5:49 AM, Jinpu Wang wrote:
> > On Sun, Mar 1, 2020 at 1:51 AM Bart Van Assche <bvanassche@xxxxxxx> wrote:
> >>
> >> On 2020-02-21 02:47, Jack Wang wrote:
> >>> +struct rtrs_clt {
> >>> + struct list_head /* __rcu */ paths_list;
> >>
> >> The commented out __rcu is confusing. Please remove it and add an
> >> elaborate comment if paths_list is a list head with nonstandard behavior.
> > Will change to a normal comment, we want to use rculist, but no such
> > annotation usage for normal list_head, only hlist_head in kernel tree,
> > Do you know why?
>
> Hi Jack,
>
> I'm not aware of any annotation for RCU lists nor for RCU list elements
> that is recognized by sparse. What I do myself is to add a comment to
> each list_head that explains whether it represents a list head or a list
> element and also what the strategy is for ensuring thread-safety.
>
> Thanks,
>
> Bart.
>
Got it, thanks Bart!
