On Sun, Mar 1, 2020 at 3:47 AM Bart Van Assche <bvanassche@xxxxxxx> wrote: > > On 2020-02-21 02:47, Jack Wang wrote: > > +/* Structure which binds N devices and N sessions */ > > +struct rnbd_srv_sess_dev { > > + /* Entry inside rnbd_srv_dev struct */ > > + struct list_head dev_list; > > + /* Entry inside rnbd_srv_session struct */ > > + struct list_head sess_list; > > + struct rnbd_dev *rnbd_dev; > > + struct rnbd_srv_session *sess; > > + struct rnbd_srv_dev *dev; > > + struct kobject kobj; > > + struct completion *sysfs_release_compl; > > + u32 device_id; > > + fmode_t open_flags; > > + struct kref kref; > > + struct completion *destroy_comp; > > + char pathname[NAME_MAX]; > > + enum rnbd_access_mode access_mode; > > +}; > Please indent structure members consistently. Anyway: Will do. > Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx> Thank you!