Re: [PATCH v9 15/25] block/rnbd: private headers with rnbd protocol structs and helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-02-21 02:47, Jack Wang wrote:
> +/**
> + * struct rnbd_msg_hdr - header of RNBD messages
> + * @type:	Message type, valid values see: enum rnbd_msg_types
> + */
> +struct rnbd_msg_hdr {
> +	__le16		type;
> +	__le16		__padding;
> +};

Please add a BUILD_BUG_ON() somewhere that checks the size of the
structures that represent the wire protocol.

> +static inline u32 rnbd_op(u32 flags)
> +{
> +	return (flags & RNBD_OP_MASK);
> +}
> +
> +static inline u32 rnbd_flags(u32 flags)
> +{
> +	return (flags & ~RNBD_OP_MASK);
> +}

No parentheses around returned values please.

Thanks,

Bart.



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux