On 2020/2/23 7:38, Jason Gunthorpe wrote: >> Hi Jason, >> >> Do you means >> >> udata->outlen >= sizeof(*resp) >> >> should be changed into: >> >> udata->out_len >= offsetof(typeof(*resp), cap_flags) >> >> If yes, I will fix other similar codes with this issue in hns drivers. > Probably offsetofend though, right? > > But yes, that is how the general 'feature test for old userspace with > old kernel ABI' should look > > Jason > Yes, you are right, I made a mistake :) Thanks for your comments. Weihang
