On Thu, Feb 20, 2020 at 08:34:00AM -0500, Dennis Dalessandro wrote: > On 2/20/2020 2:12 AM, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > > There is no need to set driver version in in-tree kernel code. > > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > --- > > drivers/infiniband/ulp/ipoib/ipoib.h | 2 -- > > drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 3 --- > > drivers/infiniband/ulp/ipoib/ipoib_main.c | 4 ---- > > 3 files changed, 9 deletions(-) > > > > Same comments as the other patch, can we just remove the field from the > drvinfo struct altogether. Ahh, and extra thing. I put default version in ->version before calling to the driver. It allows for out-of-tree drivers overwrite that field and continue to manage their internal versions. Thanks > > Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> >
