> Subject: Re: [RFC PATCH v4 18/25] RDMA/irdma: Implement device supported > verb APIs > > On Wed, Feb 12, 2020 at 11:14:17AM -0800, Jeff Kirsher wrote: > > > +/** > > + * irdma_ib_register_device - register irdma device to IB core > > + * @iwdev: irdma device > > + */ > > +int irdma_ib_register_device(struct irdma_device *iwdev) { > > + int ret; > > + > > + ret = irdma_init_rdma_device(iwdev); > > + if (ret) > > + return ret; > > + > > + rdma_set_device_sysfs_group(&iwdev->ibdev, &irdma_attr_group); > > New drivers are forbidden from calling this: > OK. Agreed. What's exported via query device suffices.