Re: [PATCH for-next v2 1/2] IB/core: Add option to retrieve driver gid context from ib_gid_attr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 19, 2019 at 7:48 PM Jason Gunthorpe <jgg@xxxxxxxx> wrote:
>
> On Thu, Dec 19, 2019 at 10:36:45AM +0530, Selvin Xavier wrote:
> > > Instead I guess a new symbol as rdma_get_gid_attr_context() can be added
> > > too.
> > I am okay with both adding context to gid_attr struct or adding a symbol.
> > Let me know your preference.
> > Or shall i handle this inside bnxt_re itself. Not sure whether any
> > other drivers intend to use this.
>
> Having a function to return the same void * that is passed to the
> driver ops functions seems reasonable and small to me.
Posting a patch with a symbol that returns void *

Thanks

>
> But you could also spruce this up a bit and have it work more like a
> true 'priv' and get rid of that void *..
>
> The container_of thing is really odd
>
> Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux