-----"Krishnamraju Eraparaju" <krishna2@xxxxxxxxxxx> wrote: ----- >To: "Jason Gunthorpe" <jgg@xxxxxxxxxxxx> >From: "Krishnamraju Eraparaju" <krishna2@xxxxxxxxxxx> >Date: 02/10/2020 07:00PM >Cc: dledford@xxxxxxxxxx, bmt@xxxxxxxxxxxxxx, >linux-rdma@xxxxxxxxxxxxxxx, bharat@xxxxxxxxxxx, nirranjan@xxxxxxxxxxx >Subject: [EXTERNAL] Re: [PATCH for-review/for-rc/for-rc] RDMA/siw: >Remove unwanted WARN_ON in siw_cm_llp_data_ready() > >On Friday, February 02/07/20, 2020 at 10:18:20 -0400, Jason Gunthorpe >wrote: >> On Fri, Feb 07, 2020 at 05:22:09PM +0530, Krishnamraju Eraparaju >wrote: >> > Warnings like below can fill up the dmesg while disconnecting >RDMA >> > connections. >> > Hence, removing the unwanted WARN_ON. >> >> Please explain why it the code is correct to take this error >> path. Bernard clearly thought this shouldn't be happening >> >> Jason >As part of iSER multipath testcase, target(iw_cxgb4) responds with >MPA reject >to initiator(SIW) when iw_cxgb4 resources gets exhaused(expected as >per >testcase), then SIW performs the connection teardown and dissociates >'cep' from tcp socket 'sk'. And if any "data_ready" notifications >from >TCP stack after this connection teardown will hit WARN_ON() in >siw_cm_llp_data_ready(). > >Bernard, is this WARN_ON() useful to identify any error conditions? > Let me try recreating the issue. I'll come back asap. Thanks Bernard.