On Wed, Feb 05, 2020 at 06:41:39PM +0800, Frank Huang wrote: > hi, all > > I found that in ucma_destroy_id when using struct ucma_context not use in pair. > > 1, > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/tree/drivers/infiniband/core/ucma.c#n611 > > in line 611 ,use _ucma_find_context, do not call ucma_get_ctx > > 2, > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/tree/drivers/infiniband/core/ucma.c#n629 > > in line 629, use ucma_put_ctx > > will this cause an unexpect wait? It deserves a comment, but the ucma_put_ctx() in ucma_destroy_id pairs with the atomic_set(1) in ucma_alloc_ctx() Jason