Re: [PATCH v3] nfsd: Fix NFSv4 READ on RDMA when using readv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 04, 2020 at 01:43:56PM -0500, Chuck Lever wrote:
> 
> 
> > On Feb 4, 2020, at 12:21 PM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote:
> > 
> > On Sat, Feb 01, 2020 at 03:05:19PM -0500, Chuck Lever wrote:
> >> Changes since RFC2:
> >> - Take Trond's suggestion to use xdr->buf->len
> >> - Squash fix down to a single patch
> > 
> > I liked them better split out.
> > 
> > This seems fine to me, though.
> > 
> > Could you ping me again in another week, after the merge window?
> > 
> >> @@ -3521,17 +3521,14 @@ static __be32 nfsd4_encode_readv(struct nfsd4_compoundres *resp,
> >> 	u32 zzz = 0;
> >> 	int pad;
> >> 
> >> +	/* Ensure xdr_reserve_space skips past xdr->buf->head */
> > 
> > Could the comment explain why we're doing this?  (Maybe take some
> > language from the changelog.)
> 
> The new comment will also explain why the patches are combined.
> I'll send a v4 after the merge window closes.

Hah, OK, thanks!

--b.



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux