On Mon, Feb 03, 2020 at 11:53:47PM +0530, Devesh Sharma wrote:
> On Mon, Feb 3, 2020 at 11:48 PM Gal Pressman <galpress@xxxxxxxxxx> wrote:
> >
> > On 03/02/2020 17:56, Devesh Sharma wrote:
> > > diff --git a/libibverbs/driver.h b/libibverbs/driver.h
> > > index a0e6f89..fc0699d 100644
> > > --- a/libibverbs/driver.h
> > > +++ b/libibverbs/driver.h
> > > @@ -84,6 +84,7 @@ enum verbs_qp_mask {
> > > enum ibv_gid_type {
> > > IBV_GID_TYPE_IB_ROCE_V1,
> > > IBV_GID_TYPE_ROCE_V2,
> > > + IBV_GID_TYPE_INVALID
> > > };
> >
> > I don't think that's right.
> > You're adding a new enum value to libibverbs, but it's not really
> > used/implemented there.
> > If devinfo needs an invalid GID value, make it local to that program.
>
> the enum can be used by other applications too, if those are yet to be
> coded in future. I thought its a good practice to put things at one
> place once for all.
Yes, as long as IBV_GID_TYPE_INVALID can be returned by ibv_query_gid_type(),
but it doesn't.
Thanks
