On Thu, Jan 30, 2020 at 11:07:17AM -0500, Dennis Dalessandro wrote: > On 1/30/2020 3:39 AM, Leon Romanovsky wrote: > > On Thu, Jan 30, 2020 at 10:20:49AM +0200, Kamal Heib wrote: > > > The proper return code is "-EOPNOTSUPP" when the requested QP type is > > > not supported by the provider. > > > > > > Signed-off-by: Kamal Heib <kamalheib1@xxxxxxxxx> > > > --- > > > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 2 +- > > > drivers/infiniband/hw/cxgb4/qp.c | 2 +- > > > drivers/infiniband/hw/hns/hns_roce_qp.c | 2 +- > > > drivers/infiniband/hw/i40iw/i40iw_verbs.c | 2 +- > > > drivers/infiniband/hw/mlx4/qp.c | 2 +- > > > drivers/infiniband/hw/mlx5/qp.c | 2 +- > > > drivers/infiniband/hw/mthca/mthca_provider.c | 2 +- > > > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +- > > > drivers/infiniband/hw/qedr/verbs.c | 2 +- > > > drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- > > > drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c | 2 +- > > > drivers/infiniband/sw/rdmavt/qp.c | 2 +- > > > drivers/infiniband/sw/siw/siw_verbs.c | 2 +- > > > 13 files changed, 13 insertions(+), 13 deletions(-) > > > > *_err() prints definitely should go too. Simple user space > > application will create DDOS on dmesg with those prints. > > > > I would say that other prints should be removed too or at least > > put in general way inside the caller of ->create_qp() callback. > > I'd agree but I don't think that has to be done in this patch. This looks > fine to me. No doubts, I simply want to reduce the amount of churn. Thanks > > -Denny > >
