RE: [PATCH for-next 1/7] RDMA/bnxt_re: Refactor queue pair creation code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> From: linux-rdma-owner@xxxxxxxxxxxxxxx <linux-rdma-
> owner@xxxxxxxxxxxxxxx> On Behalf Of Devesh Sharma


>  drivers/infiniband/hw/bnxt_re/bnxt_re.h  |  13 +-
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 635 ++++++++++++++++++++---------

[..]
> +
> +	/* remove from active qp list */
> +	mutex_lock(&rdev->qp_lock);
> +	list_del(&gsi_sqp->list);
> +	atomic_dec(&rdev->qp_count);

Atomic inc/dec/read should not be protected using qp_lock mutex.
Please take it outside the critical section in new refactor code and in old one.

> +	mutex_unlock(&rdev->qp_lock);




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux