On Mon, Jan 27, 2020 at 06:21:08AM -0800, Jakub Kicinski wrote: > On Mon, 27 Jan 2020 08:45:34 +0200, Leon Romanovsky wrote: > > > The thing is that we don't consider in-kernel API as stable one, so > > > addition of new field which is not in use in upstream looks sketchy to > > > me, but I have an idea how to solve it. > > > > Actually, it looks like my idea is Jakub's and Michal's idea. I will use > > this opportunity and remove MODULE_VERSION() too. > > If you do please make sure DKMS works. I remember it was looking at > that value. I'll check, thanks. However from reading the source, it will be unlikely to see any issues there. DKMS uses modversion for two things. First is to manage internal tree where those modules will be built and it knows how to install and clean automatically modules. Second is to list modaliases, and it handles them perfectly with and without version [1]. In our case, modules version will be available, it just going to change from 1.0.0. to something like 5.5.0-rc6. [1] https://github.com/dell/dkms/blob/master/dkms_find-provides#L48 Thanks
