On Mon, Jan 27, 2020 at 01:21:14PM +0100, David Miller wrote: > From: Leon Romanovsky <leon@xxxxxxxxxx> > Date: Mon, 27 Jan 2020 07:49:55 +0200 > > > We, RDMA and many other subsystems mentioned in that ksummit thread, > > removed MODULE_VERSION() a long time ago and got zero complains from > > the real users. > > Changes to RDMA have a disproportionate level of impact compared to > all of netdev. > > So comparing the level of real or perceived potential impact is quite > intellectually dishonest. This whole discussion was more emotional than intellectual :). Anyway, I sent v4 https://lore.kernel.org/linux-rdma/20200127072028.19123-1-leon@xxxxxxxxxx and that variant provides default version value without harming out-of-tree modules. I have a plan to start and remove ethtool version and MODULE_VERSION() calls from the drivers/net/* modules after merge window completes. Does this plan sound right to you? Thanks