On Thu, Jan 16, 2020 at 03:26:58PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/infiniband/hw/hfi1/msix.c:136:22: warning: overlapping > comparisons always evaluate to false [-Wtautological-overlap-compare] > if (type < IRQ_SDMA && type >= IRQ_OTHER) > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ > 1 warning generated. > > It is impossible for something to be less than 0 (IRQ_SDMA) and greater > than or equal to 3 (IRQ_OTHER) at the same time. A logical OR should > have been used to keep the same logic as before. > > Link: https://github.com/ClangBuiltLinux/linux/issues/841 > Fixes: 13d2a8384bd9 ("IB/hfi1: Decouple IRQ name from type") > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx> > Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > Acked-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> > --- > drivers/infiniband/hw/hfi1/msix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason
