On Thu, Jan 23, 2020 at 06:40:06AM -0800, Jakub Kicinski wrote: > On Thu, 23 Jan 2020 15:05:41 +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > > In order to stop useless driver version bumps and unify output > > presented by ethtool -i, let's overwrite the version string. > > > > Before this change: > > [leonro@erver ~]$ ethtool -i eth0 > > driver: virtio_net > > version: 1.0.0 > > After this change: > > [leonro@server ~]$ ethtool -i eth0 > > driver: virtio_net > > version: 5.5.0-rc6+ > > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > I wonder how hard it would be to tell Coccinelle to remove all prints > in the drivers. Removing related defines would probably be a little > painful/manual. Hm.. It is also unclear how can we automatically catch new comers. > > Anyway, you gotta rebase on net-next, the ethtool code got moved around > :) I tried it now and It applies cleanly on top of commit 6d9f6e6790e7 Merge branch 'net-sched-add-Flow-Queue-PIE-packet-scheduler' Thanks