On Wed, Jan 22, 2020 at 04:41:10PM +0000, Michal Kalderon wrote: > > From: Leon Romanovsky <leon@xxxxxxxxxx> > > Sent: Wednesday, January 22, 2020 6:15 PM > > > > External Email > > > > ---------------------------------------------------------------------- > > On Wed, Jan 22, 2020 at 04:03:04PM +0000, Michal Kalderon wrote: > > > > From: linux-rdma-owner@xxxxxxxxxxxxxxx <linux-rdma- > > > > owner@xxxxxxxxxxxxxxx> On Behalf Of Jakub Kicinski > > > > > > > > On Wed, 22 Jan 2020 17:26:26 +0200, Michal Kalderon wrote: > > > > > Add to debug dump more information on the platform it was > > > > > collected from (kernel version, epoch, pci func, path id). > > > > > > > > Kernel version and epoch don't belong in _device_ debug dump. > > > This is actually very useful when customers provide us with a debug-dump > > using the ethtool-d option. > > > We can immediately verify the linux kernel version used. > > > > Why can't they give you "uname -a" output? > Unfortunately, history has shown us that in many cases even though requested uname -a is not > Provided, or worse, provided but does not match the actual kernel run on. > Having this information in the dump helps us and provides us with more confidence than uname -a output. I don't buy it, if user can't provide adequate "uname -a", you can't trust his "ethtool -d" dump file too. Thanks > > > > > Thanks