> From: linux-rdma-owner@xxxxxxxxxxxxxxx <linux-rdma-
> owner@xxxxxxxxxxxxxxx> On Behalf Of Jason Gunthorpe
>
> The set of entry->driver_removed is missing locking, protect it with
> xa_lock() which is held by the only reader.
>
> Otherwise readers may continue to see driver_removed = false after
> rdma_user_mmap_entry_remove() returns and may continue to try and
> establish new mmaps.
>
> Fixes: 3411f9f01b76 ("RDMA/core: Create mmap database and cookie helper
> functions")
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> ---
> drivers/infiniband/core/ib_core_uverbs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/infiniband/core/ib_core_uverbs.c
> b/drivers/infiniband/core/ib_core_uverbs.c
> index b7cb59844ece45..b51bd7087a881f 100644
> --- a/drivers/infiniband/core/ib_core_uverbs.c
> +++ b/drivers/infiniband/core/ib_core_uverbs.c
> @@ -232,7 +232,9 @@ void rdma_user_mmap_entry_remove(struct
> rdma_user_mmap_entry *entry)
> if (!entry)
> return;
>
> + xa_lock(&entry->ucontext->mmap_xa);
> entry->driver_removed = true;
> + xa_unlock(&entry->ucontext->mmap_xa);
> kref_put(&entry->ref, rdma_user_mmap_entry_free); }
> EXPORT_SYMBOL(rdma_user_mmap_entry_remove);
> --
Thanks,
Acked-by: Michal Kalderon <michal.kalderon@xxxxxxxxxxx>
> 2.24.1
