On Thu, Jan 16, 2020 at 03:24:04PM -0400, Jason Gunthorpe wrote: > On Thu, Jan 16, 2020 at 09:32:08AM +0200, Leon Romanovsky wrote: > > > 2. IMHO, you don't need to include your selftest in final patches, because > > the whole series is going to be accepted and that code will be added and > > deleted at the same time. Especially printk part. > > I like seeing the tests. For a patch like this, which is so tedious to > review, it makes the review a check of the tests, a check of the > spatch and some spot checks of the transformations. > > Since it is a small number of lines, and it is much easier than > sending the tests separately, it felt reasonable to leave them in the > history. > > Will you be able to send the _be removal conversions you had done on > top of this? It will time to make rebase, but I'll do. > > I didn't show it, but all the private_data_len, etc should be some > generic IBA_NUM_BYTES() accessor like get/set instead of more #defines. > > Jason
