On Wed, 15 Jan 2020 15:12:49 +0100
Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote:
> From: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
>
> The 'clean' rule in the samples/bpf Makefile tries to remove backup
> files (ending in ~). However, if no such files exist, it will instead try
> to remove the user's home directory. While the attempt is mostly harmless,
> it does lead to a somewhat scary warning like this:
>
> rm: cannot remove '~': Is a directory
>
> Fix this by using find instead of shell expansion to locate any actual
> backup files that need to be removed.
>
> Fixes: b62a796c109c ("samples/bpf: allow make to be run from samples/bpf/ directory")
> Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
Kind of scary make clean command!
Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
> ---
> samples/bpf/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
> index 5b89c0370f33..f86d713a17a5 100644
> --- a/samples/bpf/Makefile
> +++ b/samples/bpf/Makefile
> @@ -254,7 +254,7 @@ all:
>
> clean:
> $(MAKE) -C ../../ M=$(CURDIR) clean
> - @rm -f *~
> + @find $(CURDIR) -type f -name '*~' -delete
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
