Make sure to return -EINVAL when the supplied string is bigger then
the node_desc array.
Fixes: c5bcbbb9fe00 ("IB: Allow userspace to set node description")
Signed-off-by: Kamal Heib <kamalheib1@xxxxxxxxx>
---
drivers/infiniband/core/sysfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
index 087682e6969e..aa90a42d6565 100644
--- a/drivers/infiniband/core/sysfs.c
+++ b/drivers/infiniband/core/sysfs.c
@@ -1268,7 +1268,9 @@ static ssize_t node_desc_store(struct device *device,
if (!dev->ops.modify_device)
return -EOPNOTSUPP;
- memcpy(desc.node_desc, buf, min_t(int, count, IB_DEVICE_NODE_DESC_MAX));
+ if (strscpy(desc.node_desc, buf, sizeof(desc.node_desc)) == -E2BIG)
+ return -EINVAL;
+
ret = ib_modify_device(dev, IB_DEVICE_MODIFY_NODE_DESC, &desc);
if (ret)
return ret;
--
2.21.1
