On 2020/1/3 21:39, Jason Gunthorpe wrote: > On Fri, Jan 03, 2020 at 01:57:22PM +0800, Weihang Li wrote: > > >> This patch has no relationship with the userspace one you pointed out. >> But I have pushed a userspace patch that support extended atomic on hip08, >> maybe you were asking about the following one: >> >> https://github.com/linux-rdma/rdma-core/pull/638 > > Right, sorry > >> The kernel part is not needed by the userspace part, they are independent >> of each other. >> >> We made this patch because we noticed that some other providers has also >> support this feature in kernel, maybe there will be some kernel users in >> future. I would be grateful if you could give me more suggestions. > > I think we have no kernel users of extended atomics, it is probably an > mistake that other providers implemented this in the kernel. > > I would advise against making the hns send path more complicated with > dead code. > > Jason > > Hi Jason, Thanks for your reminder about extended atomic in kernel and sorry for the delayed response. We cancel this patch as your suggestion, and will send another one which the user space extended atomic is dependent on. Weihang
