> On Jan 7, 2020, at 8:47 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Wed, Dec 18, 2019 at 08:20:20AM -0500, Chuck Lever wrote: >> >> >>> On Dec 18, 2019, at 12:36 AM, Leon Romanovsky <leon@xxxxxxxxxx> wrote: >>> >>> On Wed, Dec 18, 2019 at 12:22:19AM +0000, Jason Gunthorpe wrote: >>>> On Mon, Dec 16, 2019 at 10:53:43AM -0500, Chuck Lever wrote: >>>>> Hey y'all- >>>>> >>>>> Refresh of the RDMA/core trace point patches. Anything else needed >>>>> before these are acceptable? >>>> >>>> Can Leon compile and run it yet? >>> >>> Nope, it is enough to apply first patch to see compilation error. >> >> I've never seen that here. There is another report of this problem >> with an earlier version of the series, so I thought it had been >> resolved. >> >> I'll look into it. > > You tend to need a line like: > > ccflags-y += -I $(srctree)/$(src) # needed for trace events Thanks, that was exactly the one-line fix applied in v10 of this series. > to ensure the trace header actually gets included for out of source > tree builds. Or move the trace header to include/trave/events/. I find > that annoying for simple modules, but for a subsystem where the trace > header might be spread over various directories that might end up being > much easier. -- Chuck Lever
