> Subject: Re: [PATCH v4] infiniband: i40iw: fix a potential NULL pointer dereference > > On Mon, Dec 30, 2019 at 10:24:28AM +0800, Xiyu Yang wrote: > > A NULL pointer can be returned by in_dev_get(). Thus add a > > corresponding check so that a NULL pointer dereference will be avoided > > at this place. > > > > Fixes: 8e06af711bf2 ("i40iw: add main, hdr, status") > > Signed-off-by: Xiyu Yang <xiyuyang19@xxxxxxxxxxxx> > > Signed-off-by: Xin Tan <tanxin.ctf@xxxxxxxxx> > > Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > --- > > Changes in v2: > > - Release rtnl lock when in_dev_get return NULL Changes in v3: > > - Continue the next loop when in_dev_get return NULL Changes in v4: > > - Change commit message > > > > drivers/infiniband/hw/i40iw/i40iw_main.c | 2 ++ > > 1 file changed, 2 insertions(+) > > Applied to for-next > > And Shiraz, Leon is right, that trylock stuff is completely wrong, let's fix it. > Sure.