On Thu, Jan 02, 2020 at 05:50:45PM +0000, Saleem, Shiraz wrote: > > Subject: Re: [PATCH v3 19/20] RDMA: Add irdma Kconfig/Makefile and remove > > i40iw > > > > On Thu, Jan 02, 2020 at 04:00:37PM +0000, Saleem, Shiraz wrote: > > > > Subject: Re: [PATCH v3 19/20] RDMA: Add irdma Kconfig/Makefile and > > > > remove i40iw > > > > > > > > > > > > > > - The whole cqp_compl_thread thing looks really weird > > > > > What is the concern? > > > > > > > > It looks like an open coded work queue > > > > > > > > > > The cqp_compl_thread is not a work queue in the sense that no work is > > > queued to it. It is a thread that is signaled to check for and handle > > > CQP completion events if present. > > > > How is that not a work queue? The work is the signal to handle CQP completion > > events. > > > > Yes we could use the work as a signal. But this would mean, > we allocate a work item, initialize it to an 'identical' value, > queue it up and then free it. You don't have to allocate a work item every time. > Why is this better than using a single kthread that just > wake ups to handle the CQP completion? We'd have endless kthreads if people did this everytime they needed a bit of async work. Jason
