> in_dev_get may return a NULL object. I would prefer a wording like “A null pointer can be returned by in_dev_get().”. > The fix handles the situation > by adding a check to avoid NULL pointer dereference on idev, > as pick_local_ipaddrs does. How do you think about the wording suggestion “Thus add a corresponding check so that a null pointer dereference will be avoided at this place.”? Please add also the tag “Fixes” to your change description. Regards, Markus
