I agree with you, Leon. I have fixed several problems similar to this in the Linux upstream. Not sure whether this problem is fixed or not in Linux upstream. Zhu Yanjun On Wed, Dec 25, 2019 at 5:29 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > On Wed, Dec 25, 2019 at 03:23:53PM +0800, Frank Huang wrote: > > hi leon > > > > I can not get what you means, do you say the rxe_add_ref(qp) is not needed? > > It is not what I'm saying. > > The use of rxe_add_ref(qp) assumes that QP can't disappear while it is > called. From what I see in the code, rxe_responder() doesn't guarantee > that. > > Thanks